Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1130)

Issue 5504122: Issue 395" Support for move-only types in Gmock.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by ajwong
Modified:
9 years, 6 months ago
Reviewers:
Vlad
CC:
googlemock_googlegroups.com
Base URL:
http://googlemock.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M include/gmock/gmock-spec-builders.h View 3 chunks +7 lines, -3 lines 0 comments Download
M include/gmock/internal/gmock-port.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 1
ajwong
12 years, 4 months ago (2012-01-04 02:49:23 UTC) #1
This is a really really rough start but I wanted to pass this by you first.

For C++98/C++03 where there is no standard "move" mechanism, I think we should
use Koenig resolution to allow a gmock client to override the move function.

With this code change, I can now get the following to compile

class MyMock {
  MOCK_METHOD0(TakesOwnership, void(Foo::MoveOnlyType m);
};

Assuming I also declare a

namespace Foo {
MoveOnlyType move(MoveOnlyType m);
}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b