Issue 5504102: cocoa devdraw: activation on receiving Ttop messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5504102: cocoa devdraw: activation on receiving Ttop messages

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by djeannot24

Modified:
12 years, 4 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Description

cocoa devdraw: activation on receiving Ttop messages (The new variable "willactivate" is in the input structure "in", which is illogical. But this structure will soon be renamed "app". I postpone the renaming to avoid conflicts with simultaneous Codereview issues.)

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -2 lines)			Patch
M	src/cmd/devdraw/cocoa-screen.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/devdraw/cocoa-screen.m	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	src/cmd/devdraw/cocoa-srv.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

12 years, 4 months ago (2012-01-16 22:04:31 UTC) #2

*** Submitted as 2ee9fdd741ad ***

cocoa devdraw: activation on receiving Ttop messages

(The new variable "willactivate" is in the input
structure "in", which is illogical.  But this
structure will soon be renamed "app".  I postpone
the renaming to avoid conflicts with simultaneous
Codereview issues.)

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5504102

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages