code review 5504082: dashboard: fix todo caching nil

dashboard: fix todo caching nil

[adg, 2011-12-23 04:58:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-12-23 05:03:15]

LGTM

On Thu, Dec 22, 2011 at 8:58 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> dashboard: fix todo caching nil
>
> Please review this at
http://codereview.appspot.com/**5504082/<http://codereview.appspot.com/5504082/>
>
> Affected files:
>  M misc/dashboard/app/build/**handler.go
>
>
> Index: misc/dashboard/app/build/**handler.go
> ==============================**==============================**=======
> --- a/misc/dashboard/app/build/**handler.go
> +++ b/misc/dashboard/app/build/**handler.go
> @@ -152,11 +152,10 @@
>        c := appengine.NewContext(r)
>        now := cache.Now(c)
>        key := "build-todo-" + r.Form.Encode()
> -       cachedTodo := new(Todo)
> -       if cache.Get(r, now, key, cachedTodo) {
> -               return cachedTodo, nil
> +       var todo *Todo
> +       if cache.Get(r, now, key, &todo) {
> +               return todo, nil
>        }
> -       var todo *Todo
>        var err os.Error
>        builder := r.FormValue("builder")
>        for _, kind := range r.Form["kind"] {
>
>
>

[adg, 2011-12-23 05:04:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=6bb207d24ffa ***

dashboard: fix todo caching nil

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5504082