code review 5504058: log/syslog: add Alert()

log/syslog: add Alert()

Alert logs a message using the LOG_ALERT priority.

[vadik, 2011-12-21 16:34:52]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-12-22 10:59:06]

Please add "Fixes..." line to the body of description.

On 2011/12/21 16:34:52, vadik wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

[rsc, 2011-12-22 19:28:46]

LGTM

I looked in the man page and it appears that this is
the only case were missing, so fine.  If there were
going to be 10 more I would object.

Leaving for Mikio.

http://codereview.appspot.com/5504058/diff/4001/src/pkg/log/syslog/syslog.go
File src/pkg/log/syslog/syslog.go (right):

http://codereview.appspot.com/5504058/diff/4001/src/pkg/log/syslog/syslog.go#...
src/pkg/log/syslog/syslog.go:108: // ERR logs a message using the LOG_ERR
priority.
Please change this to Err while you are here.
Not sure why it says ERR.

[vadik, 2011-12-25 15:29:33]

Hello mikioh.mikioh@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-12-26 00:32:20]

LGTM

I'll submit with "Fixes issue 2325" line.

[mikio, 2011-12-26 00:34:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=17cf5cbe5465 ***

log/syslog: add Alert method

Alert logs a message using the LOG_ALERT priority.

Fixes issue 2325.

R=mikioh.mikioh, rsc
CC=golang-dev
http://codereview.appspot.com/5504058

Committer: Mikio Hara <mikioh.mikioh@gmail.com>