Issue 5503052: code review 5503052: build: a round of fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5503052: code review 5503052: build: a round of fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
r

CC:
golang-dev

Visibility:
Public.

Description

build: a round of fixes

Patch Set 1 #

Patch Set 2 : diff -r 425928b49591 https://go.googlecode.com/hg #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
M	src/pkg/debug/gosym/pclntab_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/exp/inotify/inotify_linux_test.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/cgo/gcc_setenv.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgo/trigger.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 7 months ago (2011-12-20 22:54:38 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=f2526f5634bb *** build: a round of fixes TBR=r CC=golang-dev http://codereview.appspot.com/5503052

13 years, 7 months ago (2011-12-20 22:54:42 UTC) #2

LGTM

Expand All Messages | Collapse All Messages