Issue 5503050: code review 5503050: go: work toward build script

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5503050: code review 5503050: go: work toward build script (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/go: work toward build script The commands in the standard tree are now named by the pseudo-import paths cmd/gofmt etc. This avoids ambiguity between cmd/go's directory and go/token's parent directory.

Patch Set 1 #

Patch Set 2 : diff -r d8089c662171 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d8089c662171 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d8089c662171 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e932eb65eeb5 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 6 : diff -r 1317c6000b13 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -64 lines)			Patch
M	src/cmd/gc/runtime.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/unsafe.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/go/build.go	View	1 2 3 4 5	20 chunks	+166 lines, -50 lines	0 comments	Download
M	src/cmd/go/list.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/go/main.go	View	1 2	2 chunks	+35 lines, -7 lines	0 comments	Download
M	src/cmd/go/pkg.go	View	1	3 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-20 20:57:22 UTC) #1

please make the CLs for this command say cmd/go: adsfasdfasdf just having an unqualified 'go' ...

13 years, 7 months ago (2011-12-20 21:00:26 UTC) #2

LGTM http://codereview.appspot.com/5503050/diff/5007/src/cmd/go/build.go File src/cmd/go/build.go (right): http://codereview.appspot.com/5503050/diff/5007/src/cmd/go/build.go#newcode555 src/cmd/go/build.go:555: // fmtcmd replaces the name of the GOROOT ...

13 years, 7 months ago (2011-12-20 21:10:05 UTC) #3

rsc

13 years, 7 months ago (2011-12-20 21:42:48 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=9bccb4a32e4a ***

cmd/go: work toward build script

The commands in the standard tree are now named
by the pseudo-import paths cmd/gofmt etc.
This avoids ambiguity between cmd/go's directory
and go/token's parent directory.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5503050

Expand All Messages | Collapse All Messages