Issue 5502091: cocoa devdraw: neutralize menu and Dock bugs in fullscreen mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5502091: cocoa devdraw: neutralize menu and Dock bugs in fullscreen mode

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by djeannot24

Modified:
12 years, 4 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Description

cocoa devdraw: neutralize menu and Dock bugs in fullscreen mode Previously, the menu bar has been set to hidden instead of autohidden in fullscreen mode, because it appeared too easily. Occasionally however, it still appears. This patch makes sure it won't. With OS X Lion's fullscreen, the Dock is autohidden, but sometimes remains hidden. This bug comes with visual menu bar bugs during space transition and when exiting fullscreen. Those bugs happen after each Devdraw's activation, for example. This patch neutralizes them.

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	src/cmd/devdraw/cocoa-screen.m	View		3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

12 years, 4 months ago (2012-01-16 22:11:39 UTC) #2

*** Submitted as 11df8fb1cb6c ***

devdraw: OS X: neutralize menu and Dock bugs in fullscreen mode

Previously, the menu bar has been set to hidden
instead of autohidden in fullscreen mode, because
it appeared too easily.  Occasionally however, it
still appears.  This patch makes sure it won't.

With OS X Lion's fullscreen, the Dock is
autohidden, but sometimes remains hidden.  This
bug comes with visual menu bar bugs
during space transition and when exiting
fullscreen.  Those bugs happen after each
Devdraw's activation, for example.  This patch
neutralizes them.

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5502091

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages