code review 5502074: go/doc: don't ignore anonymous non-exported fields

go/doc: don't ignore anonymous non-exported fields

- remove wrapper.go from testing package (not needed anymore)

Fixes issue 1000.

[gri, 2011-12-23 08:43:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[niemeyer, 2011-12-23 21:07:54]

Not comfortable with the code base, but it works for me, and looks sensible.

[gri, 2011-12-23 23:43:00]

Thanks for the feedback.

I agree, this code needs to be rewritten at this point - this can be
much much cleaner. It's a stop-gap measure for now. I may have some
time over the holidays.

Merry Xmas!
- Robert

On Fri, Dec 23, 2011 at 1:07 PM,  <n13m3y3r@gmail.com> wrote:
> Not comfortable with the code base, but it works for me, and looks
> sensible.
>
> http://codereview.appspot.com/5502074/

[gri, 2012-01-10 20:44:35]

Hello rsc@golang.org, golang-dev@googlegroups.com, n13m3y3r@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-11 20:52:08]

Looks pretty good.  I patched it in and ran 'godoc .'
in a directory containing only this:


package p

type T struct {
	ptrMeth
	valMeth
	*ptrMeth1
	*valMeth1
}

type ptrMeth struct{}
func (*ptrMeth) PtrMeth() {}

type ptrMeth1 struct{}
func (*ptrMeth1) PtrMeth1() {}

type valMeth struct{}
func (valMeth) ValMeth() {}

type valMeth1 struct{}
func (valMeth1) ValMeth1() {}

It prints:

type T struct {
    // contains filtered or unexported fields
}

func (*T) PtrMeth()

func (*T) PtrMeth1()

func (T) ValMeth()

func (*T) ValMeth1()

I believe the output should be

func (*T) PtrMeth()  // same as above

func (T) PtrMeth1()  // no * here (the embedded field has a * so the
receiver does not require one)

func (T) ValMeth()  // same as above

func (T) ValMeth1()  // no * here (it's a value method)

[gri, 2012-01-12 00:29:04]

PTAL.

A doc_test.go is in the works for a next CL.
- gri

On Wed, Jan 11, 2012 at 12:52 PM, Russ Cox <rsc@golang.org> wrote:
> Looks pretty good.  I patched it in and ran 'godoc .'
> in a directory containing only this:
>
>
> package p
>
> type T struct {
>        ptrMeth
>        valMeth
>        *ptrMeth1
>        *valMeth1
> }
>
> type ptrMeth struct{}
> func (*ptrMeth) PtrMeth() {}
>
> type ptrMeth1 struct{}
> func (*ptrMeth1) PtrMeth1() {}
>
> type valMeth struct{}
> func (valMeth) ValMeth() {}
>
> type valMeth1 struct{}
> func (valMeth1) ValMeth1() {}
>
> It prints:
>
> type T struct {
>    // contains filtered or unexported fields
> }
>
> func (*T) PtrMeth()
>
> func (*T) PtrMeth1()
>
> func (T) ValMeth()
>
> func (*T) ValMeth1()
>
> I believe the output should be
>
> func (*T) PtrMeth()  // same as above
>
> func (T) PtrMeth1()  // no * here (the embedded field has a * so the
> receiver does not require one)
>
> func (T) ValMeth()  // same as above
>
> func (T) ValMeth1()  // no * here (it's a value method)

[gri, 2012-01-12 19:41:34]

Hello rsc@golang.org, golang-dev@googlegroups.com, n13m3y3r@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-12 23:19:29]

LGTM

[gri, 2012-01-13 00:04:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=044f408c2471 ***

go/doc: don't ignore anonymous non-exported fields

- remove wrapper.go from testing package (not needed anymore)

Fixes issue 1000.

R=rsc, golang-dev, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5502074