Issue 5502062: code review 5502062: buildscript: make script safer, same output on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5502062: code review 5502062: buildscript: make script safer, same output on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
brainman

CC:
golang-dev, r

Visibility:
Public.

Description

buildscript: make script safer, same output on Windows

Patch Set 1 #

Patch Set 2 : diff -r 498835bf2505 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 498835bf2505 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f31b4b5afe43 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4227 lines, -4217 lines)			Patch
M	src/buildscript.sh	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	src/buildscript_darwin_386.sh	View	1 2 3	1 chunk	+301 lines, -301 lines	0 comments	Download
M	src/buildscript_darwin_amd64.sh	View	1 2 3	1 chunk	+300 lines, -300 lines	0 comments	Download
M	src/buildscript_freebsd_386.sh	View	1 2 3	1 chunk	+301 lines, -301 lines	0 comments	Download
M	src/buildscript_freebsd_amd64.sh	View	1 2 3	1 chunk	+300 lines, -300 lines	0 comments	Download
M	src/buildscript_linux_386.sh	View	1 2 3	1 chunk	+301 lines, -301 lines	0 comments	Download
M	src/buildscript_linux_amd64.sh	View	1 2 3	1 chunk	+300 lines, -300 lines	0 comments	Download
M	src/buildscript_linux_arm.sh	View	1 2 3	1 chunk	+304 lines, -304 lines	0 comments	Download
M	src/buildscript_netbsd_386.sh	View	1 2 3	1 chunk	+301 lines, -301 lines	0 comments	Download
M	src/buildscript_netbsd_amd64.sh	View	1 2 3	1 chunk	+300 lines, -300 lines	0 comments	Download
M	src/buildscript_openbsd_386.sh	View	1 2 3	1 chunk	+301 lines, -301 lines	0 comments	Download
M	src/buildscript_openbsd_amd64.sh	View	1 2 3	1 chunk	+300 lines, -300 lines	0 comments	Download
M	src/buildscript_plan9_386.sh	View	1 2 3	1 chunk	+302 lines, -302 lines	0 comments	Download
M	src/buildscript_windows_386.sh	View	1 2 3	1 chunk	+303 lines, -303 lines	0 comments	Download
M	src/buildscript_windows_amd64.sh	View	1 2 3	1 chunk	+302 lines, -302 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-21 20:46:04 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=3ee529628f53 *** buildscript: make script safer, same output on Windows R=golang-dev, r ...

13 years, 7 months ago (2011-12-21 20:58:10 UTC) #3

brainman

13 years, 7 months ago (2011-12-21 22:46:57 UTC) #4

LGTM.

I saw that problem yesterday. Was planning to look into it later. I didn't
realized buildscript_* files are regenerated as part of ./all.bash process.

Alex

Expand All Messages | Collapse All Messages