Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 5502047: code review 5502047: build: use go command during build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by rsc
Modified:
13 years, 7 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

build: use go command during build If something goes wrong, it should suffice to set USE_GO_TOOL=false in env.bash to fall back to the makefiles. I will delete the makefiles in January.

Patch Set 1 #

Patch Set 2 : diff -r d8089c662171 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d8089c662171 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9bccb4a32e4a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9bccb4a32e4a https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 9bccb4a32e4a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7739 lines, -46 lines) Patch
A src/buildscript.sh View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A src/buildscript_darwin_386.sh View 1 2 3 1 chunk +546 lines, -0 lines 0 comments Download
A src/buildscript_darwin_amd64.sh View 1 2 3 1 chunk +545 lines, -0 lines 0 comments Download
A src/buildscript_freebsd_386.sh View 1 2 3 1 chunk +546 lines, -0 lines 0 comments Download
A src/buildscript_freebsd_amd64.sh View 1 2 3 1 chunk +545 lines, -0 lines 0 comments Download
A src/buildscript_linux_386.sh View 1 2 3 1 chunk +546 lines, -0 lines 0 comments Download
A src/buildscript_linux_amd64.sh View 1 2 3 1 chunk +545 lines, -0 lines 0 comments Download
A src/buildscript_linux_arm.sh View 1 2 3 1 chunk +549 lines, -0 lines 0 comments Download
A src/buildscript_netbsd_386.sh View 1 2 3 1 chunk +546 lines, -0 lines 0 comments Download
A src/buildscript_netbsd_amd64.sh View 1 2 3 1 chunk +545 lines, -0 lines 0 comments Download
A src/buildscript_openbsd_386.sh View 1 2 3 1 chunk +546 lines, -0 lines 0 comments Download
A src/buildscript_openbsd_amd64.sh View 1 2 3 1 chunk +545 lines, -0 lines 0 comments Download
A src/buildscript_plan9_386.sh View 1 2 3 1 chunk +547 lines, -0 lines 0 comments Download
A src/buildscript_windows_386.sh View 1 2 3 1 chunk +548 lines, -0 lines 0 comments Download
A src/buildscript_windows_amd64.sh View 1 2 3 1 chunk +547 lines, -0 lines 0 comments Download
M src/env.bash View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/make.bash View 1 2 1 chunk +17 lines, -3 lines 0 comments Download
M src/pkg/runtime/autogen.sh View 1 1 chunk +1 line, -32 lines 0 comments Download
M src/run.bash View 1 2 3 4 1 chunk +41 lines, -11 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-12-20 21:44:39 UTC) #1
r
LGTM yay do you notice any performance difference for the build?
13 years, 7 months ago (2011-12-20 21:47:13 UTC) #2
rsc
On Tue, Dec 20, 2011 at 16:47, <r@golang.org> wrote: > do you notice any performance ...
13 years, 7 months ago (2011-12-20 21:49:01 UTC) #3
rsc
13 years, 7 months ago (2011-12-20 21:50:18 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=46c860646731 ***

build: use go command during build

If something goes wrong, it should suffice to set
USE_GO_TOOL=false in env.bash to fall back to the
makefiles.  I will delete the makefiles in January.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5502047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b