code review 5500084: encoding/json: don't marshal special float values

encoding/json: don't marshal special float values

[eds, 2011-12-28 05:43:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-01-03 01:20:46]

LGTM

But does this fix a specific issue? How were they being marshaled before?

[eds, 2012-01-03 01:26:59]

On Tue, Jan 3, 2012 at 2:20 PM,  <adg@golang.org> wrote:
> But does this fix a specific issue? How were they being marshaled
> before?

It fixes this issue:
https://groups.google.com/d/topic/golang-nuts/WjB2CVlWk8U/discussion
(There's no tracker issue)

Currently, this Go map:
map[string]float64{"infinity": math.Inf(1), "-infinity": math.Inf(-1),
"NaN": math.NaN()}

marshals to this Go string:
`{"infinity": +Inf, "-infinity": -Inf, "NaN": NaN}`

That's illegal. JSON has no way to express either infinity or NaN.

- Evan

[adg, 2012-01-03 01:30:23]

On 3 January 2012 12:26, Evan Shaw <chickencha@gmail.com> wrote:
> On Tue, Jan 3, 2012 at 2:20 PM,  <adg@golang.org> wrote:
>> But does this fix a specific issue? How were they being marshaled
>> before?
>
> It fixes this issue:
> https://groups.google.com/d/topic/golang-nuts/WjB2CVlWk8U/discussion
> (There's no tracker issue)
>
> Currently, this Go map:
> map[string]float64{"infinity": math.Inf(1), "-infinity": math.Inf(-1),
> "NaN": math.NaN()}
>
> marshals to this Go string:
> `{"infinity": +Inf, "-infinity": -Inf, "NaN": NaN}`
>
> That's illegal. JSON has no way to express either infinity or NaN.

Ok, sounds good. Thanks.

[adg, 2012-01-03 01:30:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=bfeac7c1f35e ***

encoding/json: don't marshal special float values

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5500084

Committer: Andrew Gerrand <adg@golang.org>