Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1819)

Issue 5500069: Hiding old website /web/install page

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by ambs
Modified:
12 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

changes the way make website is called (if one copy the makefile there is no point in using the makefile from the git repository, or then, there is no point in copying -- or I missed something). The solution is not texi based. Why not? because it is a patch to solve a problem that is not related with the new website, but with the old. The idea is simple, just add an index.html file under /web/install/ that redirects to downloads.html. The makefile code can be easily copied for other folders/pages that are hanging out there. I did not add them because I do not know if you like the solution. If someone wants to test, it is easy: just backup the website, and give it a shot. It should not do any malicious thing. You can also test it locally, but the redirect will not work, as I specified a absolute path.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M Documentation/contributor/website-work.itexi View 2 chunks +2 lines, -1 line 3 comments Download
A Documentation/web/server/redirect.template View 1 chunk +7 lines, -0 lines 0 comments Download
M make/website.make View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 22
Graham Percival
Sometimes I hate being right. I really wish that somebody had offered to mentor you ...
12 years, 3 months ago (2011-12-22 15:41:18 UTC) #1
ambs
http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi File Documentation/contributor/website-work.itexi (right): http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi#newcode128 Documentation/contributor/website-work.itexi:128: make -f website.make WEBSITE_ONLY_BUILD=1 \ Note that this does ...
12 years, 3 months ago (2011-12-22 16:10:39 UTC) #2
Graham Percival
http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi File Documentation/contributor/website-work.itexi (right): http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi#newcode128 Documentation/contributor/website-work.itexi:128: make -f website.make WEBSITE_ONLY_BUILD=1 \ On 2011/12/22 16:10:39, ambs ...
12 years, 3 months ago (2011-12-22 16:16:44 UTC) #3
ambs
> 1) your solution will not work because the website is not built in the ...
12 years, 3 months ago (2011-12-22 16:17:23 UTC) #4
ambs
On 2011/12/22 16:16:44, Graham Percival wrote: > http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi > File Documentation/contributor/website-work.itexi (right): > > http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi#newcode128 ...
12 years, 3 months ago (2011-12-22 16:18:33 UTC) #5
Graham Percival
On 2011/12/22 16:16:44, Graham Percival wrote: > However, using website.make from git is certainly a ...
12 years, 3 months ago (2011-12-22 16:22:08 UTC) #6
Graham Percival
On Thu, Dec 22, 2011 at 04:17:23PM +0000, hashashin@gmail.com wrote: > >2) I would not ...
12 years, 3 months ago (2011-12-22 16:25:11 UTC) #7
ambs
On Thu, Dec 22, 2011 at 4:25 PM, Graham Percival <graham@percival-music.ca> wrote: > On Thu, ...
12 years, 3 months ago (2011-12-22 16:26:57 UTC) #8
Graham Percival
On 2011/12/22 16:26:57, ambs wrote: > Will poke you when needing some more info (sorry, ...
12 years, 3 months ago (2011-12-22 16:50:19 UTC) #9
ambs
On Thu, Dec 22, 2011 at 4:50 PM, <graham@percival-music.ca> wrote: > On 2011/12/22 16:26:57, ambs ...
12 years, 3 months ago (2011-12-22 16:51:35 UTC) #10
ambs
Hello, Graham Instead of looking to the documentation files (the texi source files) I wgetted ...
12 years, 3 months ago (2011-12-22 21:03:30 UTC) #11
Graham Percival
On Thu, Dec 22, 2011 at 09:03:30PM +0000, hashashin@gmail.com wrote: > These are some results ...
12 years, 3 months ago (2011-12-22 21:18:51 UTC) #12
ambs
The detection language script is called by all the documentation files. Some examples below. doc/v2.15/Documentation/web/text-input.nl.html:190: ...
12 years, 3 months ago (2011-12-22 21:54:20 UTC) #13
ambs
testing, 1, 2, 3?
12 years, 3 months ago (2011-12-26 22:20:31 UTC) #14
ambs
Ok, sorry for this test, but something failed some seconds ago. Sending the real message ...
12 years, 3 months ago (2011-12-26 22:21:51 UTC) #15
ambs
Let me know if this is what you are thinking: 1. upload those files to ...
12 years, 3 months ago (2011-12-26 22:23:55 UTC) #16
Graham Percival
On Mon, Dec 26, 2011 at 10:23:55PM +0000, hashashin@gmail.com wrote: > Let me know if ...
12 years, 3 months ago (2011-12-27 02:30:08 UTC) #17
ambs
github pull request sent. will work next in the copy procedure.
12 years, 3 months ago (2011-12-27 19:41:05 UTC) #18
ambs
On 2011/12/27 19:41:05, ambs wrote: > github pull request sent. will work next in the ...
12 years, 3 months ago (2012-01-01 14:52:11 UTC) #19
ambs
On 2012/01/01 14:52:11, ambs wrote: > On 2011/12/27 19:41:05, ambs wrote: > > github pull ...
12 years, 3 months ago (2012-01-01 14:56:02 UTC) #20
ambs
After that code merge (hope it has the needed quality) you need to think what ...
12 years, 3 months ago (2012-01-01 14:57:33 UTC) #21
Julien Rioux
12 years ago (2012-03-17 13:19:22 UTC) #22
this rietveld issue can be closed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b