Issue 5500061: code review 5500061: os/signal: not on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5500061: code review 5500061: os/signal: not on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
bradfitz

CC:
golang-dev

Visibility:
Public.

Description

os/signal: not on windows

Patch Set 1 #

Patch Set 2 : diff -r 3c42c68dbef4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3c42c68dbef4 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/os/signal/signal.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
	M	src/pkg/os/signal/signal_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-21 13:20:23 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=ffa7e53815de *** os/signal: not on windows R=golang-dev CC=golang-dev http://codereview.appspot.com/5500061

13 years, 7 months ago (2011-12-21 13:20:29 UTC) #2

bradfitz

13 years, 7 months ago (2011-12-21 15:53:51 UTC) #3

LGTM
On Dec 21, 2011 5:20 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> os/signal: not on windows
>
> Please review this at
http://codereview.appspot.com/**5500061/<http://codereview.appspot.com/5500061/>
>
> Affected files:
>  M src/pkg/os/signal/signal.go
>  M src/pkg/os/signal/signal_test.**go
>
>
> Index: src/pkg/os/signal/signal.go
> ==============================**==============================**=======
> --- a/src/pkg/os/signal/signal.go
> +++ b/src/pkg/os/signal/signal.go
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -// +build darwin freebsd linux netbsd openbsd windows
> +// +build darwin freebsd linux netbsd openbsd
>
>  // Package signal implements operating system-independent signal handling.
>  package signal
> @@ -33,3 +33,5 @@
>        Incoming = ch
>        go process(ch)
>  }
> +
> +// BUG(rsc): This package is unavailable on Plan 9 and Windows.
> Index: src/pkg/os/signal/signal_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/os/signal/signal_**test.go
> +++ b/src/pkg/os/signal/signal_**test.go
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -// +build darwin freebsd linux netbsd openbsd windows
> +// +build darwin freebsd linux netbsd openbsd
>
>  package signal
>
>
>
>

Expand All Messages | Collapse All Messages