Issue 5500055: code review 5500055: go/doc: steps towards collecting methods of embedded types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5500055: code review 5500055: go/doc: steps towards collecting methods of embedded types (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by gri

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

go/doc: steps towards collecting methods of embedded types No visible external changes yet. The current approach is a stop-gap approach: For methods of anonymous fields to be seen, the anonymous field's types must be exported. Missing: computing the actual MethodDocs and displaying them. (Depending on the operation mode of godoc, the input to go/doc is a pre-filtered AST with all non-exported nodes removed. Non- exported anonymous fields are not even seen by go/doc in this case, and it is impossible to collect associated (even exported) methods. A correct fix will require some more significant re- engineering; AST filtering will have to happen later, possibly inside go/doc.)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -31 lines)			Patch
	M	src/pkg/go/doc/doc.go	View	1 2 3	10 chunks	+66 lines, -31 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-21 01:14:11 UTC) #1

gri

13 years, 7 months ago (2011-12-21 16:45:10 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a5559dd127ae ***

go/doc: steps towards collecting methods of embedded types

No visible external changes yet. The current approach is
a stop-gap approach: For methods of anonymous fields to be
seen, the anonymous field's types must be exported.

Missing: computing the actual MethodDocs and displaying them.

(Depending on the operation mode of godoc, the input to go/doc
is a pre-filtered AST with all non-exported nodes removed. Non-
exported anonymous fields are not even seen by go/doc in this
case, and it is impossible to collect associated (even exported)
methods. A correct fix will require some more significant re-
engineering; AST filtering will have to happen later, possibly
inside go/doc.)

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5500055

Expand All Messages | Collapse All Messages