Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(580)

Issue 5498094: cocoa devdraw: use gestures by default

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by djeannot24
Modified:
12 years, 3 months ago
Reviewers:
rsc, marius.eriksen
CC:
rsc, codebot
Visibility:
Public.

Description

Remove swipe gestures. Keep only 2-finger pinching and 3-finger tapping.

Patch Set 1 #

Patch Set 2 : drop swipe gestures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -183 lines) Patch
M src/cmd/devdraw/cocoa-screen.m View 1 8 chunks +8 lines, -183 lines 0 comments Download

Messages

Total messages: 11
djeannot24
12 years, 4 months ago (2012-01-02 00:08:15 UTC) #1
rsc
I am not sure about this particular set of gestures. I like the pinch for ...
12 years, 4 months ago (2012-01-16 22:31:11 UTC) #2
djeannot24
12 years, 4 months ago (2012-01-18 14:33:00 UTC) #3
djeannot24
I removed swipe gestures. Consequently, you can forget the 2 Acme patches regarding undo and ...
12 years, 4 months ago (2012-01-18 15:26:36 UTC) #4
rsc
What kind of events does the trackpad send if you do a 3-tap and then ...
12 years, 4 months ago (2012-01-18 15:30:32 UTC) #5
djeannot24
Cocoa sends us the following high level events: swiping, pinching, and rotating. After a 2-tap, ...
12 years, 4 months ago (2012-01-18 17:09:17 UTC) #6
rsc
LGTM
12 years, 4 months ago (2012-01-21 03:27:03 UTC) #7
rsc
*** Submitted as a8c5d2dcba94 *** devdraw: enable gestures on OS X Remove swipe gestures. Keep ...
12 years, 4 months ago (2012-01-21 03:44:36 UTC) #8
marius.eriksen
Another possibility for 2-1 is 3-fingers + physical click. Since physical clicks are the 1 ...
12 years, 3 months ago (2012-02-01 16:32:27 UTC) #9
marius.eriksen
(I agree with David that gestures really are different from mouse buttons -- but it ...
12 years, 3 months ago (2012-02-01 16:33:25 UTC) #10
djeannot24
12 years, 3 months ago (2012-02-01 17:56:16 UTC) #11
> However, the swipes really seem to come out of left
> field, and they are acme-specific.

> A cleaner way to accommodate chording would be [...]

My opinion is that chording also is Acme-specific
(but maybe I am mistaken), and that Acme's
chording is limited. Here an email I sent to Russ:

I used Acme's chording for 4 years. During that
time, I perceived those 3 limitations:

1) If you have previously selected some text, you
can't easily cut it with the mouse. You must
either reselect it, click on 'Cut' somewhere or
use the keyboard.

2) If you have previously selected some text, you
can't easily copy it with the mouse. You must
either reselect it, click on 'Snarf' somewhere or
use the keyboard.

3) If you have previously selected some text, you
can't easily replace it with the mouse. You must
either reselect it, click on 'Paste' somewhere or
use the keyboard.

With the swipe gestures, I do:

1) swipe-left anywhere in the Acme window

2) swipe-up anywhere in the Acme window

3) swipe-right anywhere in the Acme window

And I see no more limitation. All the editing is
done easily with the trackpad.

What delighted me when I discovered Acme was that
I could use it during 10 minutes before to realize
that I was using the wrong keyboard layout: so
much things could be done with just the mouse!

I think It's even more true with the trackpad.

I can even pilot Acme with my other hand now :)

The problem with swiping is that, since OS X Lion,
we don't receive swipe events anymore, unless we
change the default configuration, because a swipe
event means 3-finger, and Lion uses 3-finger by
default for Mission Control, etc.

I hope Apple will soon find a solution. A simple
one would be:

If the system uses 3-finger swipes, a swipe event means 4-finger.
If the system uses 4-finger swipes, a swipe event means 3-finger.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b