Issue 5498088: code review 5498088: gc: improve unsafe.Pointer type-check error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5498088: code review 5498088: gc: improve unsafe.Pointer type-check error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rmmh

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

gc: improve unsafe.Pointer type-check error messages Fixes issue 2627.

Patch Set 1 #

Patch Set 2 : diff -r 7ec969250bfc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7ec969250bfc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7ec969250bfc https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7ec969250bfc https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 7ec969250bfc https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/cmd/gc/typecheck.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/fixedbugs/bug390.go	View	1 2 3 4 5	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

rmmh

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-12-29 05:17:10 UTC) #1

rmmh

Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-12-29 10:06:31 UTC) #3

rmmh

Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-12-29 10:10:44 UTC) #4

rmmh

Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-12-29 10:13:06 UTC) #5

rmmh

(sorry about the duplicate mails, I was having some issues with hg change/mail)

13 years, 4 months ago (2011-12-29 10:16:13 UTC) #6

iant

13 years, 4 months ago (2012-01-06 22:34:19 UTC) #8

*** Submitted as http://code.google.com/p/go/source/detail?r=52ae6fbcc97a ***

gc: improve unsafe.Pointer type-check error messages

Fixes issue 2627.

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5498088

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages