Issue 5496065: code review 5496065: goprotobuf: update to go 1 import strings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496065: code review 5496065: goprotobuf: update to go 1 import strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
dsymonds, golang-dev

Visibility:
Public.

goprotobuf: update to go 1 import strings

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
M	compiler/descriptor/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/descriptor/descriptor.pb.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	compiler/generator/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/generator/generator.go	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
M	compiler/main.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/plugin/Makefile	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/plugin/plugin.pb.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/testdata/extension_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	proto/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	proto/all_test.go	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	proto/clone_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	proto/equal_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/lib.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	proto/text_parser_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	proto/text_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

Hello dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 10 months ago (2011-12-18 18:26:59 UTC) #1

13 years, 10 months ago (2011-12-18 21:55:37 UTC) #3

*** Submitted as e0453a3fdb6a ***

goprotobuf: update to go 1 import strings

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/5496065