Issue 5496058: code review 5496058: runtime: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496058: code review 5496058: runtime: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
r

CC:
golang-dev

Visibility:
Public.

Description

runtime: fix build I am looking forward to not supporting two build systems simultaneously. Make complains about a circular dependency still, but I don't understand it and it's probably not worth the time to figure out.

Patch Set 1 #

Patch Set 2 : diff -r f3617695d05d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f3617695d05d https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
	M	src/pkg/runtime/Makefile	View	1	4 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/pkg/runtime/Makefile.auto	View	1	3 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-16 22:58:52 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=c822c8848d97 *** runtime: fix build I am looking forward to not supporting ...

13 years, 7 months ago (2011-12-16 22:58:56 UTC) #2

LGTM

Expand All Messages | Collapse All Messages