Issue 5496050: Convert the old build_results member of PatchSet to TryJobResults

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496050: Convert the old build_results member of PatchSet to TryJobResults (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Roger Tawa

Modified:
14 years, 6 months ago

Reviewers:
M-A

Visibility:
Public.

More Reviews

Patch Set 2 : Removing all old usage of build_results string #

Total comments: 4

Patch Set 3 : Keep coding in _try_job_results() using build_strings for now #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -42 lines)			Patch
M	codereview/urls.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	codereview/views_chromium.py	View	1	1 chunk	+0 lines, -40 lines	0 comments	Download
M	fix_issue.py	View		2 chunks	+47 lines, -1 line	0 comments	Download
M	mapreduce.yaml	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

M-A

http://codereview.appspot.com/5496050/diff/2001/codereview/models.py File codereview/models.py (left): http://codereview.appspot.com/5496050/diff/2001/codereview/models.py#oldcode255 codereview/models.py:255: # Append fake object for all build_results properties. Don't ...

14 years, 6 months ago (2011-12-16 15:51:15 UTC) #2

Roger Tawa

Thanks MA. Please take another look. http://codereview.appspot.com/5496050/diff/2001/codereview/models.py File codereview/models.py (left): http://codereview.appspot.com/5496050/diff/2001/codereview/models.py#oldcode255 codereview/models.py:255: # Append fake ...

14 years, 6 months ago (2011-12-16 16:08:42 UTC) #3

M-A

14 years, 6 months ago (2011-12-16 16:27:54 UTC) #5

Pushed as
http://code.google.com/p/rietveld/source/detail?r=34e360745c66714cd1bfe209709...

Please close.

Expand All Messages | Collapse All Messages