Issue 5495061: code review 5495061: html: handle text nodes in foreign content.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5495061: code review 5495061: html: handle text nodes in foreign content. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by nigeltao

Modified:
13 years, 7 months ago

Reviewers:

CC:
andybalholm, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r e4e0c7c99d9d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e4e0c7c99d9d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 62d822e17421 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello andybalholm@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-16 04:34:21 UTC) #1

nigeltao

13 years, 7 months ago (2011-12-19 01:20:08 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=bbd65e722ad6 ***

html: handle text nodes in foreign content.

Passes tests10.dat, test 6:
<!DOCTYPE html><body><table><svg><g>foo</g></svg></table>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <svg svg>
|       <svg g>
|         "foo"
|     <table>

Also pass tests through test 12:
<!DOCTYPE
html><body><table><caption><svg><g>foo</g><g>bar</g></svg><p>baz</caption></table>

R=andybalholm
CC=golang-dev
http://codereview.appspot.com/5495061

Expand All Messages | Collapse All Messages