Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2989)

Issue 5495046: Add a plumb: url scheme to plumb.app

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robkroeger
Modified:
11 years, 6 months ago
Reviewers:
CC:
rsc, codebot
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : revised patch, per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/cmd/devdraw/macargv.m View 1 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 10
robkroeger
12 years, 4 months ago (2011-12-15 12:57:52 UTC) #1
robkroeger
This patch adds a plumb: url helper scheme to plumb.app so that links of the ...
12 years, 4 months ago (2011-12-15 13:00:07 UTC) #2
rsc
It seems like there is a lot of unnecessary syntax here (open, url, file://). Is ...
12 years, 4 months ago (2011-12-15 15:35:12 UTC) #3
robkroeger
On 2011/12/15 15:35:12, rsc wrote: > It seems like there is a lot of unnecessary ...
12 years, 4 months ago (2011-12-16 13:26:40 UTC) #4
rsc
For now let's just do plumb:<thing> means run 'plumb -d edit thing'. The script in ...
12 years, 4 months ago (2011-12-16 15:22:28 UTC) #5
robkroeger
12 years, 3 months ago (2012-02-01 12:33:42 UTC) #6
robkroeger
PTAL. Simpler patch usually means better patch. :-)
12 years, 3 months ago (2012-02-01 12:34:51 UTC) #7
robkroeger
Please take another look at the revised change.
12 years, 2 months ago (2012-02-08 11:44:34 UTC) #8
robkroeger
On 2012/02/08 11:44:34, robkroeger wrote: > Please take another look at the revised change. Hi ...
11 years, 6 months ago (2012-10-20 12:19:44 UTC) #9
rsc
11 years, 6 months ago (2012-10-21 16:53:42 UTC) #10
*** Submitted as http://code.google.com/p/plan9port/source/detail?r=64a908db98f0
***

plumb.app: accept plumb:foo as alias for foo

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5495046

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b