Issue 5494078: code review 5494078: html: handle breakout tags in foreign content.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5494078: code review 5494078: html: handle breakout tags in foreign content. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by nigeltao

Modified:
13 years, 7 months ago

Reviewers:

CC:
andybalholm, golang-dev

Visibility:
Public.

Description

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -12 lines)			Patch
	M	src/pkg/html/parse.go	View	1 2	7 chunks	+30 lines, -11 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello andybalholm@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-20 02:29:59 UTC) #1

nigeltao

13 years, 7 months ago (2011-12-20 23:00:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e30e522e4dc5 ***

html: handle breakout tags in foreign content.

Also recognize that, in the latest version of the HTML5 spec,
foreign content is not an insertion mode, but a separate concern.

Pass tests10.dat, test 13:
<!DOCTYPE
html><body><table><caption><svg><g>foo</g><g>bar</g><p>baz</table><p>quux

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <table>
|       <caption>
|         <svg svg>
|           <svg g>
|             "foo"
|           <svg g>
|             "bar"
|         <p>
|           "baz"
|     <p>
|       "quux"

Also pass tests through test 15:
<!DOCTYPE
html><body><table><colgroup><svg><g>foo</g><g>bar</g><p>baz</table><p>quux

R=andybalholm
CC=golang-dev
http://codereview.appspot.com/5494078

Expand All Messages | Collapse All Messages

Issue 5494078: code review 5494078: html: handle breakout tags in foreign content. (Closed)

Description

Patch Set 1 #

Patch Set 2 : diff -r bc56d855da64 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bc56d855da64 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bc56d855da64 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9e82f2cb91c4 https://go.googlecode.com/hg/ #

Messages