code review 5493084: image/ycbcr: move the Y'CbCr types into image and image...

image/ycbcr: move the Y'CbCr types into image and image/color.

[nigeltao, 2011-12-20 08:56:00]

Hello r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-12-20 09:07:51]

This patch also deletes these two files:
src/pkg/image/ycbcr/ycbcr.go
src/pkg/image/ycbcr/ycbcr_test.go

I guess that codereview got confused because I used "hg move" on them. But those
files are indeed listed in .hg/codereview/cl.5493084.

[r, 2011-12-20 16:53:25]

LGTM
rsc should check the gofix

http://codereview.appspot.com/5493084/diff/4001/src/pkg/image/color/ycbcr.go
File src/pkg/image/color/ycbcr.go (right):

http://codereview.appspot.com/5493084/diff/4001/src/pkg/image/color/ycbcr.go#...
src/pkg/image/color/ycbcr.go:72: // of one luma and two chroma components.
"for each of one" reads funny. tweak:
having 8 bits each for one luma and two chroma

http://codereview.appspot.com/5493084/diff/4001/src/pkg/image/color/ycbcr.go#...
src/pkg/image/color/ycbcr.go:76: // speaking, the term YUV applies only to
analog video signals.
if you're being pedantic, and you should, explain Y' vs Y for the uninitiated.

[rsc, 2011-12-20 17:07:45]

gofix looks good

[nigeltao, 2011-12-20 23:29:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=74e1aeb2f0a3 ***

image/ycbcr: move the Y'CbCr types into image and image/color.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5493084