Issue 5493061: code review 5493061: runtime: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5493061: code review 5493061: runtime: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
r, frichter, r2

CC:
golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 479bba71fb07 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 479bba71fb07 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	src/Make.pkg	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/Makefile	View	1	5 chunks	+8 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-16 20:46:23 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=6ec0a5c12d75 *** runtime: fix build TBR=r CC=golang-dev http://codereview.appspot.com/5493061

13 years, 7 months ago (2011-12-16 20:46:27 UTC) #2

frichter

*# arm-specific object files*56*OFILES_arm=\*61*OFILES_arm=\*57*memset_arm.$O\ *62* memset_arm.$O\*58* softfloat_arm.$O\*63* softfloat_arm.$O\*59*vlop_arm.$O\ *64* vlop_arm.$O\*60* vlrt_arm.$O\*65* vlrt_arm.$O\*66* traceback_x86.$O\* *traceback_x86* looks ...

13 years, 7 months ago (2011-12-17 06:08:16 UTC) #4

thanks for the report. fixed.

-rob

Expand All Messages | Collapse All Messages