Issue 5492064: code review 5492064: os: Add NetBSD support for recent signal changes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5492064: code review 5492064: os: Add NetBSD support for recent signal changes.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by m4dh4tt3r

Modified:
13 years, 4 months ago

Reviewers:
jsing

CC:
golang-dev, jsing

Visibility:
Public.

Description

os: Add NetBSD support for recent signal changes. Add NetBSD to mksignals.sh and generate files. While we're here, also add netbsd to the +build list where appropriate.

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -11 lines)			Patch
M	src/pkg/os/dir_unix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/error_posix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/exec/lp_unix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/exec_posix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/exec_unix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/file_posix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/file_unix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/mksignals.sh	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/os/os_unix_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/path_unix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/sys_bsd.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/user/lookup_stubs.go	View	1 chunk	+1 line, -1 line	0 comments	Download
A	src/pkg/os/zsignal_netbsd_386.go	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	src/pkg/os/zsignal_netbsd_amd64.go	View	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

m4dh4tt3r

Hello golang-dev@googlegroups.com (cc: jsing@google.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-12-17 00:43:24 UTC) #1

jsing

On 2011/12/17 00:43:24, m4dh4tt3r wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:jsing@google.com), > > I'd like you ...

13 years, 4 months ago (2011-12-17 15:09:05 UTC) #2

jsing

13 years, 4 months ago (2011-12-17 15:29:26 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=15b63cc10b22 ***

os: Add NetBSD support for recent signal changes.

Add NetBSD to mksignals.sh and generate files.
While we're here, also add netbsd to the +build list where appropriate.

R=golang-dev, jsing
CC=golang-dev
http://codereview.appspot.com/5492064

Committer: Joel Sing <jsing@google.com>

Expand All Messages | Collapse All Messages