Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 5491062: code review 5491062: net: DialTimeout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by bradfitz
Modified:
13 years, 7 months ago
Reviewers:
CC:
adg1, dsymonds, rsc, r, mikio, golang-dev
Visibility:
Public.

Description

net: DialTimeout Fixes issue 240

Patch Set 1 #

Patch Set 2 : diff -r e03f5fc4f701 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e03f5fc4f701 https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 4 : diff -r ab010ea28439 https://go.googlecode.com/hg #

Patch Set 5 : diff -r ab010ea28439 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 6 : diff -r d96df215f3b5 https://go.googlecode.com/hg #

Patch Set 7 : diff -r d96df215f3b5 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -1 line) Patch
M src/pkg/net/dial.go View 1 2 3 4 3 chunks +65 lines, -1 line 0 comments Download
A src/pkg/net/dial_test.go View 1 2 3 4 5 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 14
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-12-16 19:41:58 UTC) #1
adg1
http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go#newcode77 src/pkg/net/dial.go:77: // The timeout includes any address resolution time. s/any.+$/name ...
13 years, 7 months ago (2011-12-17 05:08:53 UTC) #2
dsymonds
LGTM http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go#newcode83 src/pkg/net/dial.go:83: t := time.NewTimer(timeout) On 2011/12/17 05:08:53, adg1 wrote: ...
13 years, 7 months ago (2011-12-17 06:37:06 UTC) #3
bradfitz
http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go#newcode112 src/pkg/net/dial.go:112: err := &OpError{ On 2011/12/17 05:08:53, adg1 wrote: > ...
13 years, 7 months ago (2011-12-17 16:27:22 UTC) #4
adg1
On Saturday, December 17, 2011, <dsymonds@golang.org> wrote: > LGTM > > > http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go > File ...
13 years, 7 months ago (2011-12-18 01:08:55 UTC) #5
rsc
LGTM nice nested select
13 years, 7 months ago (2011-12-19 21:42:54 UTC) #6
bradfitz
hah, didn't even notice. Let me add a test & re-ping. On Mon, Dec 19, ...
13 years, 7 months ago (2011-12-19 21:44:17 UTC) #7
r
http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5491062/diff/4001/src/pkg/net/dial.go#newcode78 src/pkg/net/dial.go:78: func DialTimeout(net, addr string, timeout time.Duration) (Conn, error) { ...
13 years, 7 months ago (2011-12-19 21:51:37 UTC) #8
bradfitz
From the name alone, I'd interpret DialWithin like it was dialing from a given local ...
13 years, 7 months ago (2011-12-19 21:56:27 UTC) #9
bradfitz
Hello adg@google.com, dsymonds@golang.org, rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 7 months ago (2011-12-19 23:48:13 UTC) #10
dsymonds
LGTM http://codereview.appspot.com/5491062/diff/2003/src/pkg/net/dial.go File src/pkg/net/dial.go (right): http://codereview.appspot.com/5491062/diff/2003/src/pkg/net/dial.go#newcode78 src/pkg/net/dial.go:78: func DialTimeout(net, addr string, timeout time.Duration) (Conn, error) ...
13 years, 7 months ago (2011-12-20 00:22:41 UTC) #11
mikio
LGTM http://codereview.appspot.com/5491062/diff/2003/src/pkg/net/dial_test.go File src/pkg/net/dial_test.go (right): http://codereview.appspot.com/5491062/diff/2003/src/pkg/net/dial_test.go#newcode25 src/pkg/net/dial_test.go:25: if runtime.GOOS == "windows" { For now, please ...
13 years, 7 months ago (2011-12-20 01:14:47 UTC) #12
bradfitz
Hello adg@google.com, dsymonds@golang.org, rsc@golang.org, r@golang.org, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 7 months ago (2011-12-20 21:06:17 UTC) #13
bradfitz
13 years, 7 months ago (2011-12-20 21:17:43 UTC) #14
*** Submitted as http://code.google.com/p/go/source/detail?r=0e775d9b9ad1 ***

net: DialTimeout

Fixes issue 240

R=adg, dsymonds, rsc, r, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5491062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b