Issue 5490078: code review 5490078: strconv: remove obsolete comment.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5490078: code review 5490078: strconv: remove obsolete comment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by iant

Modified:
13 years, 7 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 2f499059697f https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	src/pkg/strconv/ftoa.go	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-12-20 01:09:25 UTC) #1

rsc

LGTM http://codereview.appspot.com/5490078/diff/1/src/pkg/strconv/ftoa.go File src/pkg/strconv/ftoa.go (right): http://codereview.appspot.com/5490078/diff/1/src/pkg/strconv/ftoa.go#newcode43 src/pkg/strconv/ftoa.go:43: // necessary such that Atof32 will return f ...

13 years, 7 months ago (2011-12-20 03:45:18 UTC) #3

iant

13 years, 7 months ago (2011-12-20 04:57:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d64d82e2391d ***

strconv: remove obsolete comment.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5490078

Expand All Messages | Collapse All Messages