Hi, This patch fixes the insane values in runs and run_max field of the program ...
13 years, 4 months ago
(2011-12-16 22:37:15 UTC)
#1
Hi,
This patch fixes the insane values in runs and run_max field of the
program summary. This can happen when the gcda files manually removed
from the output directory after the merge happens.
This is for google branch only.
Tested with (make; make check).
-Rong
2011-12-16 Rong Xu <xur@google.com>
* libgcc/libgcov.c (gcov_merge_gcda_file): reset summary_pos.
Index: libgcc/libgcov.c
===================================================================
--- libgcc/libgcov.c (revision 182398)
+++ libgcc/libgcov.c (working copy)
@@ -810,6 +810,7 @@
gcov_unsigned_t tag, length;
eof_pos = 0;
+ summary_pos = 0;
tag = gcov_read_unsigned ();
if (tag)
--
This patch is available for review at http://codereview.appspot.com/5490057
Ok for google branches -- not applicable to trunk. David On Fri, Dec 16, 2011 ...
13 years, 4 months ago
(2011-12-16 22:43:31 UTC)
#2
Ok for google branches -- not applicable to trunk.
David
On Fri, Dec 16, 2011 at 2:37 PM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch fixes the insane values in runs and run_max field of the
> program summary. This can happen when the gcda files manually removed
> from the output directory after the merge happens.
>
> This is for google branch only.
>
> Tested with (make; make check).
>
> -Rong
>
> 2011-12-16 Rong Xu <xur@google.com>
>
> * libgcc/libgcov.c (gcov_merge_gcda_file): reset summary_pos.
>
> Index: libgcc/libgcov.c
> ===================================================================
> --- libgcc/libgcov.c (revision 182398)
> +++ libgcc/libgcov.c (working copy)
> @@ -810,6 +810,7 @@
> gcov_unsigned_t tag, length;
>
> eof_pos = 0;
> + summary_pos = 0;
>
> tag = gcov_read_unsigned ();
> if (tag)
>
> --
> This patch is available for review at http://codereview.appspot.com/5490057
Issue 5490057: [google] fix insane runs in gcda file
Created 13 years, 4 months ago by xur
Modified 13 years, 4 months ago
Reviewers: davidxl
Base URL: svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/
Comments: 0