Issue 5489141: CG: clarify what countdown means

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5489141: CG: clarify what countdown means (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by janek

Modified:
12 years, 4 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

CG: clarify what countdown means CG currently sounds like "countdown is the time when developers can review a patch", but it's not true. Developers can review a patch since it's uploaded, the countdown is only a warning/reminder about a patch.

Patch Set 1 #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Documentation/contributor/introduction.itexi	View		1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival

LGTM http://codereview.appspot.com/5489141/diff/1/Documentation/contributor/introduction.itexi File Documentation/contributor/introduction.itexi (right): http://codereview.appspot.com/5489141/diff/1/Documentation/contributor/introduction.itexi#newcode175 Documentation/contributor/introduction.itexi:175: "last chance" to review the patch. If no ...

12 years, 4 months ago (2012-01-03 21:37:00 UTC) #2

janek

12 years, 4 months ago (2012-01-03 22:03:16 UTC) #3

pushed as c1a1f9684b6cfab2e4b4d813db6058c7d22b9b0a

http://codereview.appspot.com/5489141/diff/1/Documentation/contributor/introd...
File Documentation/contributor/introduction.itexi (right):

http://codereview.appspot.com/5489141/diff/1/Documentation/contributor/introd...
Documentation/contributor/introduction.itexi:175: "last chance" to review the
patch.  If no significant problems are
On 2012/01/03 21:37:00, Graham Percival wrote:
> change:
>   a "last chance"
> to:
>   one last chance
> 
> then push directly to staging.

Done.

Expand All Messages | Collapse All Messages