Updates makelsr to point to lilypond exe

The CG discussing makelsr says "Make sure that convert-ly and lilypond commands in current PATH are in a bleeding edge version" but in practice the it constructs a path to convert-ly, but not to the lilypond exe.  The only indication that lilypond isn't found is a cryptic "sh: lilypond: not found" in the middle of reams of output.  This update uses the same path to lilypond as to convert-ly which avoids the need for a correct PATH statement.  The exe is used to check that the files being converted are real lilypond ones and not some unsafe command.

If this patch is accepted, I'll update the CG with details.

[PhilEHolmes, 2012-01-02 12:37:13]

Please review

[Graham Percival, 2012-01-02 21:11:39]

great idea!  A few implementation quibbles, though.

http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):

http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py#newc...
scripts/auxiliar/makelsr.py:76: lilypondexe=conv_path+'lilypond'
I have a slight preference for
  lilypond_bin
but this isn't a serious complaint.

http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py#newc...
scripts/auxiliar/makelsr.py:184: e = os.system (lilypondexe + " -dno-print-pages
-dsafe -o /tmp/lsrtest " + dest)
1. why did you remove the -V flag?
2. AFAIK if you simply do + dest, it will break if there are any snippets with a
space in the filename.  I think that as a policy we don't allow those, but the
'%s' % dest  solution avoids that potential problem.  Why not keep it there?

[email_philholmes.net, 2012-01-04 17:37:30]

----- Original Message ----- 
From: <graham@percival-music.ca>
To: <PhilEHolmes@googlemail.com>; <percivall@gmail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Monday, January 02, 2012 9:11 PM
Subject: Re: Updates makelsr to point to lilypond exe (issue 5489134)


> great idea!  A few implementation quibbles, though.

Thought I'd responded to this, but can't find a record of doing so.

>
> http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py
> File scripts/auxiliar/makelsr.py (right):
>
>
http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py#newc...
> scripts/auxiliar/makelsr.py:76: lilypondexe=conv_path+'lilypond'
> I have a slight preference for
>   lilypond_bin
> but this isn't a serious complaint.

No worries - I'll change it.

>
http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py#newc...
> scripts/auxiliar/makelsr.py:184: e = os.system (lilypondexe + "
> -dno-print-pages -dsafe -o /tmp/lsrtest " + dest)
> 1. why did you remove the -V flag?

Because, IMHO, it produces a load of spurious garbage that is rarely of any 
interest for any reason.  It certainly doesn't add anything to running 
makelsr - it just clutters the output out - it could be removed with more 
redirections, but I've got other places to sort that out.

> 2. AFAIK if you simply do + dest, it will break if there are any
> snippets with a space in the filename.  I think that as a policy we
> don't allow those, but the '%s' % dest  solution avoids that potential
> problem.  Why not keep it there?
>
> http://codereview.appspot.com/5489134/

I couldn't make the %s syntax work.  If you could quickly save me some time 
and provide syntax, I'll do it.

--
Phil Holmes

[Graham Percival, 2012-01-04 22:20:45]

ok, I'm fine with removing the -V.

http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):

http://codereview.appspot.com/5489134/diff/1/scripts/auxiliar/makelsr.py#newc...
scripts/auxiliar/makelsr.py:184: e = os.system (lilypondexe + " -dno-print-pages
-dsafe -o /tmp/lsrtest " + dest)
 e = os.system ("%s -dno-print-pages -dsafe -o /tmp/lsrtest '%s'" %
(lilypondexe, dest))

should do the trick