Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 5489091: code review 5489091: strconv: fix bug in extended-float based conversion. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by remyoudompheng
Modified:
13 years, 7 months ago
Reviewers:
CC:
rsc, golang-dev, remy_archlinux.org
Visibility:
Public.

Description

strconv: fix bug in extended-float based conversion. A test intended for denormals erroneously returned true also for infinities, leading to bad overflows and wrong error estimates.

Patch Set 1 #

Patch Set 2 : diff -r 1bf987b51921 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1bf987b51921 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 9b9dc55a7745 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/pkg/strconv/atof_test.go View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M src/pkg/strconv/extfloat.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-12-19 23:07:50 UTC) #1
remyoudompheng
Did anyone take a look? Rémy.
13 years, 7 months ago (2011-12-22 07:28:25 UTC) #2
rsc
I guess it is the other test case that was being handled incorrectly? http://codereview.appspot.com/5489091/diff/4001/src/pkg/strconv/atof_test.go File ...
13 years, 7 months ago (2011-12-22 13:33:37 UTC) #3
remyoudompheng
http://codereview.appspot.com/5489091/diff/4001/src/pkg/strconv/atof_test.go File src/pkg/strconv/atof_test.go (right): http://codereview.appspot.com/5489091/diff/4001/src/pkg/strconv/atof_test.go#newcode120 src/pkg/strconv/atof_test.go:120: {"1.7976931348623157e+308", "1.7976931348623157e+308", nil}, On 2011/12/22 13:33:37, rsc wrote: > ...
13 years, 7 months ago (2011-12-22 21:42:35 UTC) #4
remyoudompheng
Hello rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
13 years, 7 months ago (2011-12-22 21:45:50 UTC) #5
rsc
LGTM Thanks so much for all these.
13 years, 7 months ago (2011-12-22 21:51:02 UTC) #6
rsc
13 years, 7 months ago (2011-12-22 22:28:39 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=9cf398f17907 ***

strconv: fix bug in extended-float based conversion.

A test intended for denormals erroneously returned true also for
infinities, leading to bad overflows and wrong error estimates.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/5489091

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b