code review 5489082: net/http: test both texta and textb values, not texta twice

net/http: test both texta and textb values, not texta twice

[brainman, 2011-12-19 01:11:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-12-19 03:43:34]

LGTM

On Sun, Dec 18, 2011 at 5:11 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: test both texta and textb values, not texta twice
>
> Please review this at
http://codereview.appspot.com/**5489082/<http://codereview.appspot.com/5489082/>
>
> Affected files:
>  M src/pkg/net/http/request_test.**go
>
>
> Index: src/pkg/net/http/request_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/request_**test.go
> +++ b/src/pkg/net/http/request_**test.go
> @@ -202,8 +202,8 @@
>        if g, e := req.FormValue("texta"), textaValue; g != e {
>                t.Errorf("texta value = %q, want %q", g, e)
>        }
> -       if g, e := req.FormValue("texta"), textaValue; g != e {
> -               t.Errorf("texta value = %q, want %q", g, e)
> +       if g, e := req.FormValue("textb"), textbValue; g != e {
> +               t.Errorf("textb value = %q, want %q", g, e)
>        }
>        if g := req.FormValue("missing"); g != "" {
>                t.Errorf("missing value = %q, want empty string", g)
>
>
>

[brainman, 2011-12-19 06:31:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=113217f9853a ***

net/http: test both texta and textb values, not texta twice

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5489082