code review 5489062: net, syscall: interface address and mask

net, syscall: interface address and mask

This CL makes both InterfaceAddrs and Addrs method on Interface
return IPNet struct for representing interface address and mask
like below:

interface "lo0": flags "up|loopback|multicast", ifindex 1, mtu 16384
        interface address "fe80::1/64"
        interface address "127.0.0.1/8"
        interface address "::1/128"
        joined group address "ff02::fb"
        joined group address "224.0.0.251"
        joined group address "ff02::2:65d0:d71e"
        joined group address "224.0.0.1"
 	joined group address "ff01::1"
        joined group address "ff02::1"
        joined group address "ff02::1:ff00:1"

Fixes issue 2571.

[mikio, 2011-12-16 07:17:10]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-12-16 08:29:31]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-12-16 15:44:53]

Is there a reason to define InterfaceAddr instead of using IPNet directly?

[mikio, 2011-12-16 16:25:43]

On Sat, Dec 17, 2011 at 12:44 AM, Russ Cox <rsc@golang.org> wrote:

> Is there a reason to define InterfaceAddr instead of using IPNet directly?

no, does it matter?

[rsc, 2011-12-16 16:27:16]

It just seems like an extra type to learn about.

[mikio, 2011-12-16 16:35:42]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-12-17 06:54:41]

I did sleep on it but seems like no good reason exists.

Users will (assert and) wrap IPNet, use own type for something
wonderful. Looks like there's nothing useful, should be abstracted
by net package, informations in kernel, platform-dependent stuff.

Okay, PTAL.

On Sat, Dec 17, 2011 at 1:27 AM, Russ Cox <rsc@golang.org> wrote:
> It just seems like an extra type to learn about.

[mikio, 2011-12-17 06:55:06]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-12-18 11:46:59]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-12-20 01:11:41]

ping

On 2011/12/18 11:46:59, mikioh wrote:
> Hello mailto:golang-dev@googlegroups.com, mailto:rsc@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[rsc, 2011-12-21 04:21:39]

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_bsd.go
File src/pkg/net/interface_bsd.go (right):

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_bsd.go#ne...
src/pkg/net/interface_bsd.go:22: err  error
How about using := throughout and not needing the var block?

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_bsd.go#ne...
src/pkg/net/interface_bsd.go:112: err  error
Same.

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_linux.go
File src/pkg/net/interface_linux.go (right):

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_linux.go#...
src/pkg/net/interface_linux.go:21: err  error
Same

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/ip.go
File src/pkg/net/ip.go (right):

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/ip.go#newcode453
src/pkg/net/ip.go:453: // Network returns the address's network name, "route".
That's a surprising network name.
I'm not sure IPNet should implement Addr.
Is there actually anything that takes such an address?
If not, we have flexibility in the name and I'd call 
it "ip+net" or something more indicative of the actual type.

[mikio, 2011-12-21 08:58:35]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-12-21 08:59:08]

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_bsd.go
File src/pkg/net/interface_bsd.go (right):

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_bsd.go#ne...
src/pkg/net/interface_bsd.go:22: err  error
On 2011/12/21 04:21:39, rsc wrote:
> How about using := throughout and not needing the var block?

Done.

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_bsd.go#ne...
src/pkg/net/interface_bsd.go:112: err  error
On 2011/12/21 04:21:39, rsc wrote:
> Same.

Done.

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_linux.go
File src/pkg/net/interface_linux.go (right):

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/interface_linux.go#...
src/pkg/net/interface_linux.go:21: err  error
On 2011/12/21 04:21:39, rsc wrote:
> Same

Done.

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/ip.go
File src/pkg/net/ip.go (right):

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/ip.go#newcode453
src/pkg/net/ip.go:453: // Network returns the address's network name, "route".
On 2011/12/21 04:21:39, rsc wrote:
> That's a surprising network name.
> I'm not sure IPNet should implement Addr.
> Is there actually anything that takes such an address?
> If not, we have flexibility in the name and I'd call 
> it "ip+net" or something more indicative of the actual type.

yup, "route" is not good name,  I picked something 
conventional "route" from address family AF_ROUTE. 
"ip+net" sounds good to me.

http://codereview.appspot.com/5489062/diff/47/src/pkg/net/ip.go#newcode453
src/pkg/net/ip.go:453: // Network returns the address's network name, "route".
On 2011/12/21 04:21:39, rsc wrote:
> That's a surprising network name.
> I'm not sure IPNet should implement Addr.
> Is there actually anything that takes such an address?
> If not, we have flexibility in the name and I'd call 
> it "ip+net" or something more indicative of the actual type.

Done.

[mikio, 2011-12-21 12:02:52]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-12-21 12:36:57]

LGTM

[mikio, 2011-12-21 12:39:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=4c20d297d01d ***

net, syscall: interface address and mask

This CL makes both InterfaceAddrs and Addrs method on Interface
return IPNet struct for representing interface address and mask
like below:

interface "lo0": flags "up|loopback|multicast", ifindex 1, mtu 16384
        interface address "fe80::1/64"
        interface address "127.0.0.1/8"
        interface address "::1/128"
        joined group address "ff02::fb"
        joined group address "224.0.0.251"
        joined group address "ff02::2:65d0:d71e"
        joined group address "224.0.0.1"
 	joined group address "ff01::1"
        joined group address "ff02::1"
        joined group address "ff02::1:ff00:1"

Fixes issue 2571.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5489062