Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(338)

Issue 5488085: code review 5488085: undo CL 5477092 / c3c6e72d7cc5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by gri
Modified:
13 years, 8 months ago
Reviewers:
iant2
CC:
iant, golang-dev
Visibility:
Public.

Description

undo CL 5477092 / c3c6e72d7cc5 The obvious fix is breaking the build in non-obvious ways. Reverting while waiting for the correct fix, if any is needed. ««« original CL description net/http: fix bug in error checking Thanks to josef86@gmail.com for pointing this out. R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/5477092 »»»

Patch Set 1 #

Patch Set 2 : diff -r c3c6e72d7cc5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c3c6e72d7cc5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/http/transport.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
gri
Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-12-14 18:44:32 UTC) #1
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=c36450534fab *** undo CL 5477092 / c3c6e72d7cc5 The obvious fix is breaking ...
13 years, 8 months ago (2011-12-14 18:44:40 UTC) #2
iant2
13 years, 8 months ago (2011-12-14 19:14:22 UTC) #3
LGTM

gri@golang.org writes:

> Reviewers: iant,
>
> Message:
> Hello iant@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> undo CL 5477092 / c3c6e72d7cc5
>
> The obvious fix is breaking the build in non-obvious ways.
> Reverting while waiting for the correct fix, if any is needed.
>
> ««« original CL description
> net/http: fix bug in error checking
>
> Thanks to josef86@gmail.com for pointing this out.
>
> R=golang-dev, iant
> CC=golang-dev
> http://codereview.appspot.com/5477092
> »»»
>
> Please review this at http://codereview.appspot.com/5488085/
>
> Affected files:
>   M src/pkg/net/http/transport.go
>
>
> Index: src/pkg/net/http/transport.go
> ===================================================================
> --- a/src/pkg/net/http/transport.go
> +++ b/src/pkg/net/http/transport.go
> @@ -544,7 +544,7 @@
>  				resp.Header.Del("Content-Length")
>  				resp.ContentLength = -1
>  				gzReader, zerr := gzip.NewReader(resp.Body)
> -				if zerr != nil {
> +				if err != nil {
>  					pc.close()
>  					err = zerr
>  				} else {
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b