code review 5488068: json: treat renamed byte slices the same as []byte

json: treat renamed byte slices the same as []byte
Fixes issue 2163.

[r, 2011-12-13 23:02:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-13 23:07:52]

LGTM

http://codereview.appspot.com/5488068/diff/1/src/pkg/encoding/json/encode.go
File src/pkg/encoding/json/encode.go (right):

http://codereview.appspot.com/5488068/diff/1/src/pkg/encoding/json/encode.go#...
src/pkg/encoding/json/encode.go:219: var byteType = reflect.TypeOf(byte(0))
Dead?

http://codereview.appspot.com/5488068/diff/1/src/pkg/encoding/json/encode.go#...
src/pkg/encoding/json/encode.go:347: if v.Type().Elem().Kind() == reflect.Uint8
{
I'm not sure if you need to check v.Kind() == reflect.Slice too.
I don't remember if .Bytes() works on arrays.

[r, 2011-12-13 23:16:12]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-12-14 19:02:37]

LGTM

[r, 2011-12-14 19:03:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=84fd260989c3 ***

json: treat renamed byte slices the same as []byte
Fixes issue 2163.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5488068