Issue 5486061: code review 5486061: 5c, 6c, 8c: support 64-bit switch value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5486061: code review 5486061: 5c, 6c, 8c: support 64-bit switch value (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by ality

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, ken2, golang-dev

Visibility:
Public.

Description

5c, 6c, 8c: support 64-bit switch value For real this time. :-)

Patch Set 1 #

Patch Set 2 : diff -r 3a40d9aca2b6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3a40d9aca2b6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3a40d9aca2b6 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3a40d9aca2b6 https://code.google.com/p/go/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -17 lines)			Patch
M	src/cmd/5c/gc.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/5c/swt.c	View	1 2 3	2 chunks	+22 lines, -3 lines	0 comments	Download
M	src/cmd/6c/gc.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6c/swt.c	View	1 2 3	2 chunks	+17 lines, -2 lines	0 comments	Download
M	src/cmd/8c/gc.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8c/swt.c	View	1 2 3	2 chunks	+22 lines, -2 lines	0 comments	Download
M	src/cmd/cc/pgen.c	View	1 2 3 4	2 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 5 months ago (2011-12-14 06:44:51 UTC) #1

ality

Hello rsc@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2011-12-14 07:19:27 UTC) #2

rsc

13 years, 5 months ago (2011-12-14 22:30:42 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=98bda65929b6 ***

5c, 6c, 8c: support 64-bit switch value

For real this time. :-)

R=rsc, ken
CC=golang-dev
http://codereview.appspot.com/5486061

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages