code review 5486044: net/http: make test remove temporary file and directory

net/http: make test remove temporary file and directory

[iant, 2011-12-12 17:54:47]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-12-12 17:59:00]

LGTM

On Mon, Dec 12, 2011 at 9:54 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: make test remove temporary file and directory
>
> Please review this at
http://codereview.appspot.com/**5486044/<http://codereview.appspot.com/5486044/>
>
> Affected files:
>  M src/pkg/net/http/**filetransport_test.go
>
>
> Index: src/pkg/net/http/**filetransport_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/**filetransport_test.go
> +++ b/src/pkg/net/http/**filetransport_test.go
> @@ -7,6 +7,7 @@
>  import (
>        "io/ioutil"
>        "net/http"
> +       "os"
>        "path/filepath"
>        "testing"
>  )
> @@ -28,6 +29,8 @@
>        fname := filepath.Join(dname, "foo.txt")
>        err = ioutil.WriteFile(fname, []byte("Bar"), 0644)
>        check("WriteFile", err)
> +       defer os.Remove(dname)
> +       defer os.Remove(fname)
>
>        tr := &http.Transport{}
>        tr.RegisterProtocol("file", http.NewFileTransport(http.**
> Dir(dname)))
>
>
>

[iant, 2011-12-12 18:40:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=abfa952d694c ***

net/http: make test remove temporary file and directory

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5486044

[rsc, 2011-12-12 22:44:18]

Thank you!  I just discovered that today too.