Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1107)

Issue 5485055: Flexible node groups in cycles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by lukas.toenne
Modified:
12 years, 5 months ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This allows group nodes inside other group nodes in cycles and makes the code more generic for all possible cases, like direct group input-to-output links and unused group sockets. Previous code tried to connect external nodes and internal group sockets by following links until a "real" node input/output. This quickly becomes complicated in corner cases as described above and can lead to unexpected behavior when the group socket is of a different type than the internal/external sockets, but that conversion is skipped. The new code uses the concept of "proxy nodes" similar to what the new compositor does. Each group socket is replaced with a proxy node with a single input and output, to which other nodes in the same tree and internal nodes can link to. After all groups have been expanded in the graph, these proxy nodes are removed again, adding converter nodes if necessary.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -104 lines) Patch
intern/cycles/blender/blender_shader.cpp View 7 chunks +113 lines, -99 lines 0 comments Download
intern/cycles/render/graph.h View 1 chunk +1 line, -0 lines 0 comments Download
intern/cycles/render/graph.cpp View 2 chunks +51 lines, -2 lines 0 comments Download
intern/cycles/render/nodes.h View 1 chunk +8 lines, -0 lines 0 comments Download
intern/cycles/render/nodes.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_nodetree.c View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2
lukas.toenne
12 years, 5 months ago (2011-12-13 17:04:03 UTC) #1
brechtvl
12 years, 5 months ago (2011-12-16 16:25:21 UTC) #2
Can find nothing to comment on, LGTM :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b