Issue 5484044: libventi: fix segfault in vtreadpacket when not connected

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5484044: libventi: fix segfault in vtreadpacket when not connected

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by 0intro

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Description

This problem happens especially in fossil/view when vtread can be called even if not connected to venti. The old libventi handle this case properly in the function vtRPC, which is called by vtReadPacket (client.c).

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/libventi/client.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

13 years, 1 month ago (2011-12-12 21:44:54 UTC) #2

*** Submitted as 92a579c6549c ***

libventi: fix segfault in vtreadpacket when not connected

This problem happens especially in fossil/view when vtread
can be called even if not connected to venti.

The old libventi handle this case properly in the function vtRPC, which is
called by vtReadPacket (client.c).

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5484044

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages