Issue 5483054: code review 5483054: sql: fix missing mutex unlock in an error case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5483054: code review 5483054: sql: fix missing mutex unlock in an error case (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bradfitz

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

sql: fix missing mutex unlock in an error case Fixes issue 2542

Patch Set 1 #

Patch Set 2 : diff -r 0b2bc58dc830 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 0b2bc58dc830 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 2ccb0a99f1df https://go.googlecode.com/hg #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	src/pkg/exp/sql/sql.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/exp/sql/sql_test.go	View	1 2 3	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 8 months ago (2011-12-12 21:38:03 UTC) #1

LGTM i'd rather the new Test explained what it tested instead of implying a URL ...

13 years, 8 months ago (2011-12-12 21:52:43 UTC) #2

bradfitz

13 years, 8 months ago (2011-12-12 21:57:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=af0a8b44993d ***

sql: fix missing mutex unlock in an error case

Fixes issue 2542

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5483054

Expand All Messages | Collapse All Messages