Issue 5483048: code review 5483048: gc: fix use of stackallocated AST node in generation of...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5483048: code review 5483048: gc: fix use of stackallocated AST node in generation of... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by lvd

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, rog, golang-dev

Visibility:
Public.

Description

gc: fix use of stackallocated AST node in generation of static initialisation code. Fixes issue 2529

Patch Set 1 #

Patch Set 2 : diff -r 2502120cd87d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2502120cd87d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f03312eab4ce https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -14 lines)			Patch
M	src/cmd/gc/sinit.c	View	1	2 chunks	+13 lines, -14 lines	0 comments	Download
A	test/fixedbugs/bug382.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug382.dir/pkg.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org, rogpeppe@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-12-12 16:01:47 UTC) #1

lvd

13 years, 5 months ago (2011-12-13 08:09:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=19d10035bd9a ***

gc: fix use of stackallocated AST node in generation of static initialisation
code.

Fixes issue 2529

R=rsc, rogpeppe
CC=golang-dev
http://codereview.appspot.com/5483048

Expand All Messages | Collapse All Messages