Issue 5483044: code review 5483044: reflect: fix Slice cap

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5483044: code review 5483044: reflect: fix Slice cap (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by niemeyer

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, dsymonds, r, rsc

Visibility:
Public.

Description

reflect: fix Slice cap

Patch Set 1 #

Patch Set 2 : code review 5483044: reflect: fix Slice cap #

Patch Set 3 : diff -r 2502120cd87d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2502120cd87d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 30428728ac2b https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	src/pkg/reflect/all_test.go	View	1 2	1 chunk	+17 lines, -5 lines	0 comments	Download
	M	src/pkg/reflect/value.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-12-12 09:44:43 UTC) #1

rsc

LGTM If it had to be broken, that's a good way to be broken.

13 years, 8 months ago (2011-12-12 18:31:29 UTC) #4

niemeyer

13 years, 8 months ago (2011-12-12 21:45:50 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=2ccb0a99f1df ***

reflect: fix Slice cap

R=golang-dev, dsymonds, r, rsc
CC=golang-dev
http://codereview.appspot.com/5483044

Expand All Messages | Collapse All Messages