Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(116)

Issue 5482062: code review 5482062: go/build: make compatible with go/build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by rsc
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

go/build: make compatible with go/build The irony!

Patch Set 1 #

Patch Set 2 : diff -r 4d57f439ae4d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 21595dc0395a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4622983c5874 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/pkg/go/build/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/go/build/syslist.go View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-12-14 05:09:00 UTC) #1
rsc
Same problem as os: generated file now checked in.
13 years, 8 months ago (2011-12-14 05:29:25 UTC) #2
r
LGTM
13 years, 8 months ago (2011-12-14 06:16:45 UTC) #3
rsc
13 years, 8 months ago (2011-12-14 15:24:19 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=29d9095b8bc3 ***

go/build: make compatible with go/build

The irony!

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5482062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b