Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(397)

Issue 5482056: code review 5482056: gc: Use %#F in error messages instead of %F. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by lvd
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

gc: Use %#F in error messages instead of %F. Fixes issue 2520

Patch Set 1 #

Patch Set 2 : diff -r ab293785bbcc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ab293785bbcc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ab293785bbcc https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ab293785bbcc https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 7e79464f1010 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/cmd/gc/fmt.c View 1 2 3 4 1 chunk +7 lines, -3 lines 0 comments Download
A test/fixedbugs/bug383.go View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2011-12-13 09:21:54 UTC) #1
lvd
On 2011/12/13 09:21:54, lvd wrote: > Hello mailto:rsc@golang.org (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
13 years, 5 months ago (2011-12-13 11:51:30 UTC) #2
lvd
On Tue, Dec 13, 2011 at 12:51, <lvd@google.com> wrote: > On 2011/12/13 09:21:54, lvd wrote: ...
13 years, 5 months ago (2011-12-13 12:10:54 UTC) #3
rsc
LGTM
13 years, 5 months ago (2011-12-13 21:21:27 UTC) #4
lvd
13 years, 5 months ago (2011-12-14 07:22:40 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=e25954278b04 ***

gc: Use %#F in error messages instead of %F.

Fixes issue 2520

R=rsc
CC=golang-dev
http://codereview.appspot.com/5482056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b