code review 5479069: doc: remove file.go from run (fix windows build)

doc: remove file.go from run (fix windows build)

[adg, 2011-12-12 03:30:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r2, 2011-12-12 03:33:20]

how did this never come up before?

-rob

[adg, 2011-12-12 03:35:09]

On 12 December 2011 14:33, Rob 'Commander' Pike <r@google.com> wrote:
> how did this never come up before?

I added it to the list when I restructured progs/run.

Also missing was server.go.

[brainman, 2011-12-12 03:37:06]

LGTM

[r2, 2011-12-12 03:43:31]

if the problem is just that it doesn't run on windows, use a config trick. i
don't want things to not be compiled anywhere.

-rob

[brainman, 2011-12-12 03:56:00]

On 2011/12/12 03:43:31, r2 wrote:
> if the problem is just that it doesn't run on windows, use a config trick. i
> don't want things to not be compiled anywhere.
> 

One of the programs using syscall package. Syscall packages are *very* different
for different OSes. This particular code will not compile on windows.

Alex

[r2, 2011-12-12 04:06:27]

On Dec 11, 2011, at 7:56 PM, alex.brainman@gmail.com wrote:

> On 2011/12/12 03:43:31, r2 wrote:
>> if the problem is just that it doesn't run on windows, use a config
> trick. i
>> don't want things to not be compiled anywhere.
> 
> 
> One of the programs using syscall package. Syscall packages are *very*
> different for different OSes. This particular code will not compile on
> windows.

i realize that. i meant, use some Makefile magic.

-rob

[adg, 2011-12-12 04:43:18]

On 12 December 2011 14:43, Rob 'Commander' Pike <r@google.com> wrote:
> if the problem is just that it doesn't run on windows, use a config trick. i
don't want things to not be compiled anywhere.

I missed this earlier in the file:

if [ "$GOOS" = "windows" ];then
        $GC -o file.$O file_windows.go
else
        $GC file.go
fi

Not sure what the point of having file_windows.go is if it's not
included in any documentation.

It was introduced in http://golang.org/change/dc01810c2648

In short, this CL as it stands will still build file.go.

Andrew

[r, 2011-12-12 04:49:44]

LGTM

[adg, 2011-12-12 05:14:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=2502120cd87d ***

doc: remove file.go from run (fix windows build)

R=golang-dev, r, alex.brainman, r
CC=golang-dev
http://codereview.appspot.com/5479069