code review 5479043: exp/terminal: several cleanups

exp/terminal: several cleanups

1) Add EscapeCodes to the terminal so that applications don't wire
   them in.
2) Add a callback for auto-complete
3) Fix an issue with input lines longer than the width of the
   terminal.
4) Have Write() not stomp the current line. It now erases the current
   input, writes the output and reprints the prompt and partial input.
5) Support prompting without local echo in Terminal.
6) Add GetSize to report the size of terminal.

[agl1, 2011-12-08 22:27:56]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-14 21:26:43]

R=bradfitz

[bradfitz, 2011-12-14 21:34:57]

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/terminal.go
File src/pkg/exp/terminal/terminal.go (right):

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/terminal...
src/pkg/exp/terminal/terminal.go:44: Escape *EscapeCodes
needs doc, including what nil means

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/util.go
File src/pkg/exp/terminal/util.go (right):

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/util.go#...
src/pkg/exp/terminal/util.go:12: // 	        panic(err.Error())
just:

panic(err)

[agl1, 2011-12-19 22:08:15]

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/terminal.go
File src/pkg/exp/terminal/terminal.go (right):

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/terminal...
src/pkg/exp/terminal/terminal.go:44: Escape *EscapeCodes
On 2011/12/14 21:34:57, bradfitz wrote:
> needs doc, including what nil means

Done.

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/util.go
File src/pkg/exp/terminal/util.go (right):

http://codereview.appspot.com/5479043/diff/4001/src/pkg/exp/terminal/util.go#...
src/pkg/exp/terminal/util.go:12: // 	        panic(err.Error())
On 2011/12/14 21:34:57, bradfitz wrote:
> just:
> 
> panic(err) 

Done.

[agl1, 2011-12-22 16:24:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=cff4b323bd94 ***

exp/terminal: several cleanups

1) Add EscapeCodes to the terminal so that applications don't wire
   them in.
2) Add a callback for auto-complete
3) Fix an issue with input lines longer than the width of the
   terminal.
4) Have Write() not stomp the current line. It now erases the current
   input, writes the output and reprints the prompt and partial input.
5) Support prompting without local echo in Terminal.
6) Add GetSize to report the size of terminal.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5479043