Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115)

Issue 5477093: code review 5477093: http: fix failing Transport HEAD request with gzip-look... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by bradfitz
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

http: fix failing Transport HEAD request with gzip-looking response We only want to attempt to un-gzip if there's a body (not in response to a HEAD) This was accidentally passing before, but revealed to be broken when c3c6e72d7cc went in.

Patch Set 1 #

Patch Set 2 : diff -r c3c6e72d7cc5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 89bedee3e9cc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 22c0e7043027 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/net/http/transport.go View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-12-14 18:55:31 UTC) #1
rsc
LGTM
13 years, 8 months ago (2011-12-14 18:56:19 UTC) #2
bradfitz
Russ, you're slipping. This is a CL about HEAD requests being weird and you didn't ...
13 years, 8 months ago (2011-12-14 19:20:15 UTC) #3
bradfitz
13 years, 8 months ago (2011-12-14 19:20:21 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=a5fbc180090f ***

http: fix failing Transport HEAD request with gzip-looking response

We only want to attempt to un-gzip if there's a body (not in
response to a HEAD)

This was accidentally passing before, but revealed to be broken
when c3c6e72d7cc went in.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5477093
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b