Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1008)

Issue 5477087: Don't blindly issue the warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Julien Rioux
Modified:
12 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't blindly issue the warning "lilypond-book: warning: Unable to auto-detect default page settings:" Also remove the .aux file left over by lilypond-book.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M python/book_latex.py View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6
Graham Percival
LGTM, but I'm not confident enough about this patch to circumvent our review process, so ...
12 years, 4 months ago (2011-12-14 14:56:33 UTC) #1
Reinhold
LGTM. In particular, it's a good idea to call communicate() before checking the returncode, because ...
12 years, 4 months ago (2011-12-14 16:04:05 UTC) #2
Julien Rioux
Final patch ready to push. http://code.google.com/p/lilypond/issues/detail?id=2105
12 years, 4 months ago (2011-12-20 14:12:24 UTC) #3
Graham Percival
Thanks, pushed. You're responsible for closing the issue. Cheers, - Graham On Tue, Dec 20, ...
12 years, 4 months ago (2011-12-20 15:49:01 UTC) #4
Julien Rioux
On Tue, Dec 20, 2011 at 4:49 PM, Graham Percival <graham@percival-music.ca> wrote: > Thanks, pushed. ...
12 years, 4 months ago (2011-12-20 16:06:49 UTC) #5
Graham Percival
12 years, 4 months ago (2011-12-20 16:11:52 UTC) #6
On Tue, Dec 20, 2011 at 05:06:49PM +0100, Julien Rioux wrote:
> On Tue, Dec 20, 2011 at 4:49 PM, Graham Percival
> <graham@percival-music.ca> wrote:
> > Thanks, pushed.  You're responsible for closing the issue.
> 
> The google issue or the rietveld issue or both?

Both, but most importantly the google issue.

google issue: a pointer
rietveld: memory.  Very occasionally we'll look at open patches
in rietveld from people we know to see how many patches we've
lost, so closing that as well could reduce some confusion in the
future.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b