Don't blindly issue the warning
"lilypond-book: warning: Unable to auto-detect default page settings:"
Also remove the .aux file left over by lilypond-book.
LGTM, but I'm not confident enough about this patch to circumvent our review process, so ...
12 years, 4 months ago
(2011-12-14 14:56:33 UTC)
#1
LGTM, but I'm not confident enough about this patch to circumvent our review
process, so please wait for it to go through a normal countdown.
If a tex guru (like David, Werner, or Reinhold) says it's good, I'm willing to
push it to staging directly.
Thanks, pushed. You're responsible for closing the issue. Cheers, - Graham On Tue, Dec 20, ...
12 years, 4 months ago
(2011-12-20 15:49:01 UTC)
#4
Thanks, pushed. You're responsible for closing the issue.
Cheers,
- Graham
On Tue, Dec 20, 2011 at 03:12:24PM +0100, Julien Rioux wrote:
> Final patch ready to push.
>
> http://code.google.com/p/lilypond/issues/detail?id=2105
On Tue, Dec 20, 2011 at 4:49 PM, Graham Percival <graham@percival-music.ca> wrote: > Thanks, pushed. ...
12 years, 4 months ago
(2011-12-20 16:06:49 UTC)
#5
On Tue, Dec 20, 2011 at 4:49 PM, Graham Percival
<graham@percival-music.ca> wrote:
> Thanks, pushed. You're responsible for closing the issue.
The google issue or the rietveld issue or both?
Thanks,
Julien
On Tue, Dec 20, 2011 at 05:06:49PM +0100, Julien Rioux wrote: > On Tue, Dec ...
12 years, 4 months ago
(2011-12-20 16:11:52 UTC)
#6
On Tue, Dec 20, 2011 at 05:06:49PM +0100, Julien Rioux wrote:
> On Tue, Dec 20, 2011 at 4:49 PM, Graham Percival
> <graham@percival-music.ca> wrote:
> > Thanks, pushed. You're responsible for closing the issue.
>
> The google issue or the rietveld issue or both?
Both, but most importantly the google issue.
google issue: a pointer
rietveld: memory. Very occasionally we'll look at open patches
in rietveld from people we know to see how many patches we've
lost, so closing that as well could reduce some confusion in the
future.
Cheers,
- Graham
Issue 5477087: Don't blindly issue the warning
(Closed)
Created 12 years, 4 months ago by Julien Rioux
Modified 12 years, 4 months ago
Reviewers: Graham Percival, Reinhold
Base URL:
Comments: 0