Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16049)

Issue 5477053: Fix ThreadSanitizer pass required properties (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by dvyukov
Modified:
12 years, 4 months ago
Reviewers:
Diego Novillo
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fix ThreadSanitizer pass required properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M gcc/ChangeLog.google-main View 1 chunk +5 lines, -0 lines 0 comments Download
M gcc/tree-tsan.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
dvyukov
This is for google-main branch. Fix ThreadSanitizer pass required properties. Turned out that PROP_gimple_lomp is ...
12 years, 4 months ago (2011-12-09 14:36:14 UTC) #1
Diego Novillo
12 years, 4 months ago (2011-12-09 16:33:12 UTC) #2
On 11-12-09 09:36 , Dmitriy Vyukov wrote:
> This is for google-main branch.
> Fix ThreadSanitizer pass required properties.
> Turned out that PROP_gimple_lomp is not always present.
>
> Index: gcc/tree-tsan.c
> ===================================================================
> --- gcc/tree-tsan.c	(revision 182099)
> +++ gcc/tree-tsan.c	(working copy)
> @@ -1111,7 +1111,7 @@
>     NULL,                                 /* next  */
>     0,                                    /* static_pass_number  */
>     TV_NONE,                              /* tv_id  */
> -  PROP_trees | PROP_cfg,                /* properties_required  */
> +  PROP_ssa | PROP_cfg,                  /* properties_required  */
>     0,                                    /* properties_provided  */
>     0,                                    /* properties_destroyed  */
>     0,                                    /* todo_flags_start  */
> Index: gcc/ChangeLog.google-main
> ===================================================================
> --- gcc/ChangeLog.google-main	(revision 182099)
> +++ gcc/ChangeLog.google-main	(working copy)
> @@ -1,3 +1,8 @@
> +2011-12-09   Dmitriy Vyukov<dvyukov@google.com>
> +
> +	Fix ThreadSanitizer pass required properties.
> +        * gcc/tree-tsan.c (pass_tsan): Replace PROP_trees with PROP_ssa.

No need to mention what you are fixing in a ChangeLog entry.  These 
entries are merely describing what changed, with no other content (yes, 
they are pretty useless nowadays).

Also, the filename must be relative to the directory where the ChangeLog 
file lives.  So, you don't need 'gcc/' in this case.


OK with that change.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b